fix(registry): return error on failed name lookup and handle it in delete#851
Closed
madmecodes wants to merge 1 commit into
Closed
fix(registry): return error on failed name lookup and handle it in delete#851madmecodes wants to merge 1 commit into
madmecodes wants to merge 1 commit into
Conversation
…lete Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
Collaborator
|
This is a duplicate of #841, this will be decided on later. EDIT: Also please fix linting issues. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
=========================================
- Coverage 10.99% 9.00% -1.99%
=========================================
Files 173 272 +99
Lines 8671 13449 +4778
=========================================
+ Hits 953 1211 +258
- Misses 7612 12123 +4511
- Partials 106 115 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Closing - duplicates #841. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #840
Two bugs in
GetRegistryIdByName:Returns
(0, nil)when the registry name isn't found, so callerscan't distinguish "not found" from success. Fixed to return
fmt.Errorf("registry '<name>' not found").Calls
ListRegistrieswith empty opts, so the lookup only checksthe default page. Now passes the name filter so the API handles
filtering server-side.
Also fixed
registry deleteto:GetRegistryIdByNameinstead ofdiscarding it with
_strconv.ParseIntfirst so numeric IDs work as arguments tooSame pattern as the user lookup fix in #820.