fix(utils): centralize cron expression validation (closes #863)#916
Open
belnoinja wants to merge 1 commit into
Open
fix(utils): centralize cron expression validation (closes #863)#916belnoinja wants to merge 1 commit into
belnoinja wants to merge 1 commit into
Conversation
Signed-off-by: Naman <jainnaman9450035045@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #863
Cron expression validation was duplicated in two private functions:
validateCronExpressioninpkg/views/scan-all/update/view.govalidateCronincmd/harbor/root/scan_all/update_schedule.goThis PR centralizes the logic into a single reusable
utils.ValidateCronExpression(expr string) errorfunction inpkg/utils/cron.goand replaces both inline implementations with calls to it.Changes
pkg/utils/cron.go— new file withValidateCronExpression, mirrors exact existing regex and field-count behavior, no new dependenciespkg/utils/cron_test.go— 14 table-driven tests (valid expressions, empty input, wrong field counts, out-of-range values)pkg/views/scan-all/update/view.go— removed privatevalidateCronExpression, passesutils.ValidateCronExpressiondirectly to huh formValidatecallbackcmd/harbor/root/scan_all/update_schedule.go— removed privatevalidateCronand unusederrorsimport, delegates toutils.ValidateCronExpressionTesting