Refactor: move types from centralized pkg/api/types.go to domain-specific packages#917
Open
rakshityadav1868 wants to merge 1 commit into
Open
Refactor: move types from centralized pkg/api/types.go to domain-specific packages#917rakshityadav1868 wants to merge 1 commit into
rakshityadav1868 wants to merge 1 commit into
Conversation
Signed-off-by: Rakshit Yadav <yadavrakshit60@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR completes the refactoring of type definitions in the harbor-cli codebase by moving all types from the centralized
pkg/api/types.gofile to their respective domain-specific packages. This improves code organization, maintainability, and package cohesion.Fixes #667
refrence #669
Changes Made
Files Deleted
pkg/api/types.go- Centralized types file (now empty/deleted)Files Created
pkg/api/list_flags.go- SharedListFlagstype used across 10+ handlersFiles Modified
pkg/api/registry_handler.go- AddedCreateRegViewandRegistryCredentialpkg/api/member_handler.go- AddedListMemberOptions,UpdateMemberOptions,GetMemberOptionspkg/api/vulnerability_handler.go- AddedListVulnerabilityOptionspkg/api/quota_handler.go- AddedListQuotaFlagspkg/views/context/list/view.go- AddedListViewtypepkg/views/context/switch/view.go- AddedListViewtypecmd/harbor/root/context/list.go- Updated importspkg/prompt/prompt.go- Updated importsTesting
No error while building and tested using Dagger also
dagger call testanddagger call lintthere were also no errors