Skip to content

fix: handle GetRobot error in robot create and update output path to prevent nil panic #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdeshDeshmukh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle GetRobot error in robot create and update output path to prevent nil panic #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmd/harbor/root/project/robot/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,11 @@ Examples:
FormatFlag := viper.GetString("output-format")
if FormatFlag != "" {
name := response.Payload.Name
res, _ := api.GetRobot(response.Payload.ID)
res, err := api.GetRobot(response.Payload.ID)
if err != nil {
return fmt.Errorf("failed to get robot details: %v",
utils.ParseHarborErrorMsg(err))
}
utils.SavePayloadJSON(name, res.Payload)
return nil
}
Expand Down
6 changes: 5 additions & 1 deletion cmd/harbor/root/robot/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,11 @@ func createRobotAndHandleResponse(opts *create.CreateView, exportToFile bool) er

// Handle output format
if formatFlag := viper.GetString("output-format"); formatFlag != "" {
res, _ := api.GetRobot(response.Payload.ID)
res, err := api.GetRobot(response.Payload.ID)
if err != nil {
return fmt.Errorf("failed to get robot details: %v",
utils.ParseHarborErrorMsg(err))
}
utils.SavePayloadJSON(response.Payload.Name, res.Payload)
return nil
}
Expand Down
6 changes: 5 additions & 1 deletion cmd/harbor/root/robot/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,11 @@ func updateRobotAndHandleResponse(opts *update.UpdateView) error {

// Handle output format
if formatFlag := viper.GetString("output-format"); formatFlag != "" {
res, _ := api.GetRobot(opts.ID)
res, err := api.GetRobot(opts.ID)
if err != nil {
return fmt.Errorf("failed to get robot details: %v",
utils.ParseHarborErrorMsg(err))
}
utils.SavePayloadJSON(opts.Name, res.Payload)
}

Expand Down
Loading