Skip to content

fix: clean up incorrect CLI log output usage #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rakshityadav1868 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −6
Open

fix: clean up incorrect CLI log output usage #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/harbor/root/project/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ func DeleteProjectCommand() *cobra.Command {
return fmt.Errorf("failed to delete %d project(s)", len(failedDeletes))
}

log.Debug("All requested projects deleted successfully.")
return nil
},
}
Expand Down
3 changes: 1 addition & 2 deletions cmd/harbor/root/project/member/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import (
"github.com/goharbor/harbor-cli/pkg/api"
"github.com/goharbor/harbor-cli/pkg/prompt"
"github.com/goharbor/harbor-cli/pkg/utils"
log "github.com/sirupsen/logrus"
"github.com/spf13/cobra"
)

Expand Down Expand Up @@ -71,7 +70,7 @@ func DeleteMemberCommand() *cobra.Command {
}
return nil
} else if !delAllFlag {
log.Println("Please provide a username or use --all flag to delete all members")
fmt.Println("Please provide a username or use --all flag to delete all members")
memID = prompt.GetMemberIDFromUser(project, username)
if memID == 0 {
fmt.Println("No members found in project")
Expand Down
1 change: 0 additions & 1 deletion cmd/harbor/root/replication/policies/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ func UpdateCommand() *cobra.Command {

var updatedPolicy *models.ReplicationPolicy

fmt.Println("Updated policy replicate deletion:", createView.ReplicateDeletion)
if createView.ReplicationMode == "Pull" {
updatedPolicy = ConvertToPolicy(createView, existingPolicy.Payload.SrcRegistry)
updatedPolicy.ID = policyID
Expand Down
2 changes: 0 additions & 2 deletions pkg/views/member/view/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ package view

import (
"fmt"
"log"
"os"
"strconv"

Expand Down Expand Up @@ -63,7 +62,6 @@ func ViewMember(member *models.ProjectMemberEntity, wide bool) {
} else {
colsToRemove := []string{"Role ID", "Project ID"}
columns = utils.RemoveColumns(columns, colsToRemove)
log.Println(columns)
rows = append(rows, table.Row{
memberID, // Member Name
member.EntityName,
Expand Down