Skip to content

Expose information about registries as metrics#21144

Open
adberger wants to merge 3 commits intogoharbor:mainfrom
adberger:metrics
Open

Expose information about registries as metrics#21144
adberger wants to merge 3 commits intogoharbor:mainfrom
adberger:metrics

Conversation

@adberger
Copy link
Copy Markdown

@adberger adberger commented Nov 6, 2024

Comprehensive Summary of your change

With this change all registries are exposed as metrics in the harbor-exporter component.

This looks like this:

# HELP harbor_registry_info Information about the registry
# TYPE harbor_registry_info gauge
harbor_registry_info{description="",insecure="false",name="dockerhub",status="healthy",type="docker-hub",url="https://hub.docker.com"} 1

Issue being fixed

Fixes #17531 partially

Website update

goharbor/website#591

Dislaimer

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Adrian Berger added 2 commits November 6, 2024 10:25
…ector

Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
@adberger adberger requested a review from a team as a code owner November 6, 2024 09:32
@MinerYang MinerYang added the kind/requirement New feature or idea on top of harbor label Nov 11, 2024
@MinerYang MinerYang requested a review from chlins November 11, 2024 08:32
@Vad1mo Vad1mo added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Nov 13, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.29%. Comparing base (c8c11b4) to head (f655045).
Report is 326 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21144      +/-   ##
==========================================
+ Coverage   45.36%   46.29%   +0.92%     
==========================================
  Files         244      247       +3     
  Lines       13333    13863     +530     
  Branches     2719     2867     +148     
==========================================
+ Hits         6049     6418     +369     
- Misses       6983     7107     +124     
- Partials      301      338      +37     
Flag Coverage Δ
unittests 46.29% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@adberger
Copy link
Copy Markdown
Author

Friendly bump

@OrlinVasilev
Copy link
Copy Markdown
Member

@Vad1mo @wy65701436 @reasonerjt that's quite old PR can we take a look please!

@adberger
Copy link
Copy Markdown
Author

Friendly bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/requirement New feature or idea on top of harbor release-note/enhancement Label to mark PR to be added under release notes as enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more Prometheus metrics

6 participants