Skip to content

Only include functions with lines considered on the report #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcosngomezi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only include functions with lines considered on the report #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions go_coverage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,14 +171,16 @@ func getFunctionInfos(profiles []*cover.Profile) ([]*funcInfo, int64, int64, err
// Now match up functions and profile blocks.
for _, f := range funcs {
c, t := f.coverage(profile)
funcInfos = append(funcInfos,
&funcInfo{fileName: file,
functionName: f.name,
functionStartLine: f.startLine,
functionEndLine: f.endLine,
uncoveredLines: t - c})
total += t
covered += c
if t != 0 {
funcInfos = append(funcInfos,
&funcInfo{fileName: file,
functionName: f.name,
functionStartLine: f.startLine,
functionEndLine: f.endLine,
uncoveredLines: t - c})
total += t
covered += c
}
}
}
return funcInfos, total, covered, nil
Expand Down Expand Up @@ -270,9 +272,7 @@ func (f *FuncExtent) coverage(profile *cover.Profile) (num, den int64) {
covered += int64(b.NumStmt)
}
}
if total == 0 {
total = 1 // Avoid zero denominator.
}

return covered, total
}

Expand Down