Skip to content

x/arch/arm64/arm64asm: add FEAT_MOPS instruction decoding#19

Open
mauri870 wants to merge 1 commit into
golang:masterfrom
mauri870:feat-mops-arm64
Open

x/arch/arm64/arm64asm: add FEAT_MOPS instruction decoding#19
mauri870 wants to merge 1 commit into
golang:masterfrom
mauri870:feat-mops-arm64

Conversation

@mauri870

@mauri870 mauri870 commented Jun 13, 2026

Copy link
Copy Markdown
Member

DO NOT REVIEW
DO NOT SUBMIT

FEAT_MOPS (Memory Operations) is an ARM extension introduced as optional in Armv8.7 and mandatory from Armv8.8 onwards. It provides three-instruction sequences for hardware-accelerated memory copy and memory set:

CPYP/CPYM/CPYE [<Xd>]!, [<Xs>]!, <Xn>! - memory copy
SETP/SETM/SETE [<Xd>]!, <Xn>!, <Xs> - memory set

This change adds decoder support for all six instructions. The operand forms are unique to MOPS: the destination pointer is a memory write-back ([Xd]!), and the count and source registers carry explicit write-back notation (Xn!) to reflect that the CPU updates them in-place during execution. Two new Arg types are introduced to represent these forms: MemMOPS for [Xd]! and RegWriteBack for Xn!.

The per-instruction mask is 0xffe0fc00, which covers the op1[23:22] field that distinguishes the prologue, main, and epilogue variants of each family.

For golang/go#79994

FEAT_MOPS (Memory Operations) is an ARM extension introduced as
optional in Armv8.7 and mandatory from Armv8.8 onwards. It provides
three-instruction sequences for hardware-accelerated memory copy and
memory set:

  CPYP/CPYM/CPYE [<Xd>]!, [<Xs>]!, <Xn>!  - memory copy
  SETP/SETM/SETE [<Xd>]!, <Xn>!, <Xs>      - memory set

This change adds decoder support for all six instructions. The
operand forms are unique to MOPS: the destination pointer is a
memory write-back ([Xd]!), and the count and source registers carry
explicit write-back notation (Xn!) to reflect that the CPU updates
them in-place during execution. Two new Arg types are introduced to
represent these forms: MemMOPS for [Xd]! and RegWriteBack for Xn!.

The per-instruction mask is 0xffe0fc00, which covers the op1[23:22]
field that distinguishes the prologue, main, and epilogue variants
of each family.
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: ed85769) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/790441.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/790441.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants