errorgroup: producing a better failure message for a programmer error#15
errorgroup: producing a better failure message for a programmer error#15shifengbin wants to merge 1 commit intogolang:masterfrom
Conversation
|
This PR (HEAD: 51b7016) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sync/+/413094 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/413094. |
|
Message from fengbin shi: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/413094. |
|
Message from Bryan Mills: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/413094. |
|
Message from fengbin shi: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/413094. |
SetLimit(10)
Go(xx) //start a groutine ,g.done be called if task done
SetLimit(-1) //<-- g.sem=nil
but g.done is not atomic, if g.sem=nil maybe block the goroutine