Skip to content

SVS-1112 fix date dataset references #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janmatzek merged 1 commit into from
Jul 22, 2025
Merged

SVS-1112 fix date dataset references #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.idea
.vscode
.cursor
.venv*
venv/
.secrets
Expand Down
2 changes: 1 addition & 1 deletion scripts/custom_fields/input_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def _date_ref_from_field(
multivalue=False,
sources=[
CatalogDeclarativeReferenceSource(
column=custom_field.cf_id,
column=custom_field.cf_source_column,
target=CatalogGrainIdentifier(
id=custom_field.cf_id,
type=CustomFieldType.DATE.value,
Expand Down
2 changes: 1 addition & 1 deletion tests/test_custom_fields/test_input_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def test_date_ref_from_field(mock_custom_field_date):
ref = CustomFieldsDataProcessor._date_ref_from_field(mock_custom_field_date)
assert ref.identifier.id == "date1"
assert ref.sources
assert ref.sources[0].column == "date1"
assert ref.sources[0].column == "col_date1"
assert ref.sources[0].data_type == ColumnDataType.DATE.value


Expand Down