feat(gooddata-sdk): [AUTO] Add ExecutionResultLimitBreak schema for partial data detection#1628
Open
yenkins-admin wants to merge 3 commits into
Open
feat(gooddata-sdk): [AUTO] Add ExecutionResultLimitBreak schema for partial data detection#1628yenkins-admin wants to merge 3 commits into
yenkins-admin wants to merge 3 commits into
Conversation
…artial data detection
tychtjan
requested changes
May 25, 2026
Contributor
tychtjan
left a comment
There was a problem hiding this comment.
Analyze why the pipeline is failing at the unit test level ? It seems like the test you implemented doesn't work correctly. Analyse please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added ExecutionResultLimitBreak class to represent partial-data limit information from the new ExecutionResultLimitBreak OpenAPI schema. The class uses @attrs.define with fields limit (int), limit_type (str), and optional value (int|None), plus a from_dict() factory that maps camelCase API keys to snake_case. It is exported from gooddata_sdk.init. Users access limit breaks via result.metadata.get('limitBreaks') and parse each entry with ExecutionResultLimitBreak.from_dict(). Unit tests (4 parametrized cases) and an integration test with VCR cassette reference were written.
Impact: new_feature | Services:
afmSource commits (gdc-nas):
71bb41aby Mike Zelenskij — Merge pull request #22984 from gooddata/c.mze-cq-2334Files changed
packages/gooddata-sdk/src/gooddata_sdk/compute/model/limit_break.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_execution_result_limit_break.pypackages/gooddata-sdk/tests/compute/test_execution_limit_break_integration.pyAgent decisions
Decisions (3)
execution.py not modified — Standalone ExecutionResultLimitBreak class; limit breaks accessed via result.metadata raw dict
from_dict factory over Base.from_api — Custom from_dict() classmethod reading limitType camelCase to limit_type snake_case
integration test cassette strategy — Write test referencing fixtures/test_execution_result_limit_break.yaml; needs recording against server with low row-count limit
Assumptions to verify (3)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/compute/model/limit_break.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_execution_result_limit_break.pypackages/gooddata-sdk/tests/compute/test_execution_limit_break_integration.pyOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow