feat(gooddata-sdk): [AUTO] Add Anthropic LLM provider config to AFM and metadata APIs#1629
feat(gooddata-sdk): [AUTO] Add Anthropic LLM provider config to AFM and metadata APIs#1629yenkins-admin wants to merge 7 commits into
Conversation
tychtjan
left a comment
There was a problem hiding this comment.
Analyze why the unit tests in ci are failing and fix it
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1629 +/- ##
==========================================
+ Coverage 79.03% 79.25% +0.21%
==========================================
Files 231 231
Lines 15634 15659 +25
==========================================
+ Hits 12357 12411 +54
+ Misses 3277 3248 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5496e7f to
df181c4
Compare
✅ Review fixes appliedNote Addressed feedback from @tychtjan in Note 📼 Recording cassettes against staging — a follow-up commit will land shortly:
Invalidating cassettes for:
CI will be red until recording lands. That's expected. Actions✅ 1 fixed ✅ Fixed (1)
Claude output available in workflow artifacts. |
|
Tip 📼 ✅ Cassettes recorded for the requested tests.
Pushed in |
Run 26400063280 / fix-agent attempt 1 (3ed8eee) inadvertently pushed transcripts/fix-C002-attempt1.jsonl. Root cause was a recorder.py bug where cwd.parent resolved to cwd when cwd=Path("."), placing the transcript inside the SDK working tree. Fixed in gdc-nas commit 96280b1a2d.
Summary
Added Anthropic LLM provider support to the SDK wrapper. New classes CatalogAnthropicApiKeyAuth and CatalogAnthropicProviderConfig follow the exact same pattern as existing OpenAI/Bedrock/AzureFoundry providers. Deserialization (from_api) is fully functional. Write path (to_api) will require api-client regeneration to add AnthropicProviderConfig to the generated client's oneOf discriminator.
Impact: new_feature | Services:
afm,metadataSource commits (gdc-nas):
397ed1cby Jan Kadlec — Merge pull request #22516 from macekond/ome/dreamy-maxwell-20ee2dFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_organization.pyAgent decisions
Decisions (2)
client_class() for Anthropic auth/config classes — Omit client_class() override (inherit Base.client_class() returning NotImplemented)
Integration test cassette recording dependency on api-client regeneration — Write integration test referencing cassette path; note in risks that recording requires api-client regeneration
Assumptions to verify (4)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_organization.pyOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow