Skip to content

GRIF-177: Refresh token during retry for read would block error #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hung-nguyen-hoang merged 1 commit into from
May 21, 2025
Merged

GRIF-177: Refresh token during retry for read would block error #2022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.7.83
3.7.84
6 changes: 6 additions & 0 deletions lib/gooddata/rest/connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,12 @@ def retryable(options = {}, &_block)
rescue RestClient::TooManyRequests, RestClient::ServiceUnavailable, *retry_exception => e
logging_retry_error(e, retry_time)
sleep retry_time
if OpenSSL::SSL.const_defined?(:SSLErrorWaitReadable) && e.is_a?(OpenSSL::SSL::SSLErrorWaitReadable)
GoodData.gd_logger.warn "Refresh token status=start retry_time=#{retry_time}. Error: #{e.message}"
options[:refresh_token].call # (dont_reauth: true)
GoodData.gd_logger.warn "Refresh token status=success retry_time=#{retry_time}. Error: #{e.message}"
end

# Total 10 retry requests with 1.5 coefficent should take ~ 2 mins to finish
if (retries -= 1) > 0
retry_time *= RETRY_TIME_COEFFICIENT
Expand Down