Merged
Conversation
Bounded repetitions were buggy for both machine parsers, except for
character classes because they implement their own repetition. The
problems were due mainly to (a) not accounting for the parsing success
that occurred in order to reach the UPDATE instruction, and (b) not
accounting for the mincount matches that have already occurred, as they
are not tracked by the UPDATE's counter.
Before:
>>> pe.compile('"a"{1,2}', parser="machine-python").match('aaaaaa')
<Match object; span=(0, 4), match='aaaa'>
Now:
>>> pe.compile('"a"{1,2}', parser="machine-python").match('aaaaaa')
<Match object; span=(0, 2), match='aa'>
Fixes #53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounded repetitions were buggy for both machine parsers, except for character classes because they implement their own repetition. The problems were due mainly to (a) not accounting for the parsing success that occurred in order to reach the UPDATE instruction, and (b) not accounting for the mincount matches that have already occurred, as they are not tracked by the UPDATE's counter.
Before:
Now:
Fixes #53