Skip to content

Feat umi collapse#21

Open
CharlotteAnne wants to merge 9 commits intomasterfrom
feat-umiCollapse
Open

Feat umi collapse#21
CharlotteAnne wants to merge 9 commits intomasterfrom
feat-umiCollapse

Conversation

@CharlotteAnne
Copy link
Copy Markdown
Collaborator

@CharlotteAnne CharlotteAnne commented Jul 9, 2022

Add new local module UMICollapse, removed UMI tools, du and UMI length checker logic.

Notes:

  • We are using a third party docker container in the UMICollapse module, perhaps this ought to be changed, I'm not sure.
  • Currently UMICollapse is not version controlled - I suppose the docker container is the only versioning we have for this - I've asked the author to start making releases so perhaps this will change in future, so I put the version.yml as NA.
  • On the "two pass" param - apparently this increases runtime at the benefit of reducing memory footprint so whilst memory is an issue I've enabled it. In future we could remove this param to reduce runtime if that becomes an issue.

@CharlotteAnne CharlotteAnne added the enhancement New feature or request label Jul 9, 2022
@samirelanduk
Copy link
Copy Markdown
Contributor

Looks like the QC fails because it can’t find the Dedup log now - is that easy to create with the new module?

@CharlotteAnne
Copy link
Copy Markdown
Collaborator Author

cheers -- there is a log file created -- {prefix}_UMICollapse.log - can you see where i need to highlight this?

@CharlotteAnne
Copy link
Copy Markdown
Collaborator Author

I have fixed the multiQC now so this is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants