Fix assert equal chexify jit 387 #435
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387
Problem
chex.assert_equalfails withTracerBoolConversionErrorwhen used inside@chex.chexify+@jax.jitdecorated functions because it attempts tocompare traced values using
unittest.TestCase().assertEqual().Solution
Added a jittable implementation using
jnp.array_equal()and convertedassert_equalfrom a static-only assertion to a value assertion, followingthe same pattern as
assert_trees_all_equal.Changes
_assert_equal_static()- original host implementation_assert_equal_jittable()- new jittable implementation usingjnp.array_equal()_value_assertion()so chexify can use the jittable version during tracingTesting
All existing
assert_equaltests pass. The original failing example now works: