Conversation
MSVC doesn't seem to like this way of instantiating test suites...
nimrod-gileadi
suggested changes
Mar 20, 2023
Contributor
nimrod-gileadi
left a comment
There was a problem hiding this comment.
Could you paste the error message you get before this PR in the PR comment thread?
| } | ||
| } | ||
|
|
||
| #ifndef _MSC_VER |
Contributor
There was a problem hiding this comment.
Could you write a comment as to why this is needed.
Author
There was a problem hiding this comment.
I was getting the same issue @saran-t was getting here: #21
It was inscrutable to me, but I bisected commenting out regions of the file until I came to INSTANTIATE_TEST_SUITE_P, which is apparently only ever used in NormTest.cc.
I guess the Google Testing System has trouble with MSVC? Perhaps it's fixed in an updated version. 🤷♂️
Author
Author
|
Nope, MSVC still dies on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang and Ninja can be a bit squirrely to work with on Windows, but commenting out this section in
norm_test.ccallows the rest of the system to compile and run great with MSVC!EDIT: Also, you folks might appreciate this little hobby project I've been working on on the side:
https://github.com/zalo/mujoco_wasm
https://zalo.github.io/mujoco_wasm