Remove all smart_holder.h includes and PYBIND11_SMART_HOLDER_TYPE_CASTERS macros.#1317
Closed
rwgk wants to merge 1 commit into
Closed
Remove all smart_holder.h includes and PYBIND11_SMART_HOLDER_TYPE_CASTERS macros.#1317rwgk wants to merge 1 commit into
PYBIND11_SMART_HOLDER_TYPE_CASTERS macros.#1317rwgk wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
@lanctot I believe these simple changes should work with:
If that's true, you will not have to do anything special in the future. For the moment, use pybind11 master floating. After the first pybind11 v3 release you can pin to releases if you wish. |
…TERS macros. The include and the PYBIND11_SMART_HOLDER_TYPE_CASTERS were made obsolete by pybind/pybind11#5257 (merged on Jul 31, 2024).
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to #1321
Please ignore this PR.
Original description:
The smart_holder.h include and the
PYBIND11_SMART_HOLDER_TYPE_CASTERSmacros were made obsolete by pybind/pybind11#5257 (merged on Jul 31, 2024).