Add explicit checks for external tool dependencies (ffprobe, gsutil)#35
Open
ishaanxgupta wants to merge 2 commits intogoogle-deepmind:mainfrom
Open
Add explicit checks for external tool dependencies (ffprobe, gsutil)#35ishaanxgupta wants to merge 2 commits intogoogle-deepmind:mainfrom
ishaanxgupta wants to merge 2 commits intogoogle-deepmind:mainfrom
Conversation
Added a function to check for required executables and updated the download function to use it for gsutil.
Added a function to check for required executables and updated the ffprobe call to use this function.
ved015
approved these changes
Jan 5, 2026
Contributor
|
Hi @rgeirhos, looking forward to your review on this. Thanks! |
Contributor
Author
|
@rgeirhos awaiting your review on this one |
1 similar comment
Contributor
Author
|
@rgeirhos awaiting your review on this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves issue #31
This PR improves the robustness of the Physics-IQ benchmark by adding explicit validation for required external executables (ffprobe, gsutil) before they are invoked at runtime.
Currently, missing or PATH-inaccessible tools cause hard failures (e.g. FileNotFoundError) that are difficult to debug, particularly in non-root or managed environments. This change surfaces clear, actionable error messages instead.