Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @mquirosbloch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flexibility of model selection by removing the hardcoded Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the choices validation for the --model command-line argument. My review suggests restoring this validation to prevent potential runtime errors from invalid model names, adhering to best practices for command-line argument parsing.
| @@ -53,7 +53,6 @@ def main() -> int: | |||
| "--model", | |||
| default='gemini-2.5-computer-use-preview-10-2025', | |||
| help="Set which main model to use.", | |||
There was a problem hiding this comment.
By removing the choices parameter, you've disabled command-line validation for the model name. This could lead to runtime errors if an invalid model is provided. It's best to keep the choices parameter to enforce valid inputs and provide clearer error messages to the user.
help="Set which main model to use.",
choices=['gemini-2.5-computer-use-preview-10-2025', 'gemini-3-flash-preview', 'gemini-3-pro-preview'],References
- Use the
choicesparameter inargparsefor arguments with a predefined set of valid string values to enable automatic validation and help message generation.
No description provided.