Check additional YAML file paths for ratchet#43
Merged
Conversation
e7f21aa to
6cb50cd
Compare
6cb50cd to
2425b5b
Compare
Make ratchet find more files
2425b5b to
b40ec7c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the YAML file discovery for the ratchet linting tool to check additional file paths beyond just GitHub workflows and actions. The main change expands ratchet to also scan for action.yaml and action.yml files in the repository root.
- Expands ratchet file pattern to include root-level action files
- Dynamically discovers and passes ratchet-eligible files to the linting step
- Removes unused outputs for gomod-dirs and packagejson-dirs
Comments suppressed due to low confidence (2)
.github/workflows/lint.yml:71
- The regex pattern is duplicated between
match_filesandfind_filescalls. Consider extracting this pattern into a variable to avoid duplication and ensure consistency.
if match_files '(action\.(yaml|yml))|(\.github/(actions|workflows)/.*\.(yaml|yml))$'; then
.github/workflows/lint.yml:73
- Using
tr '\n' ' 'to convert newlines to spaces may cause issues if file paths contain spaces. Consider using a more robust approach like array handling or proper shell quoting.
RATCHET_FILES="$(find_files '(action\.(yaml|yml))|(\.github/(actions|workflows)/.*\.(yaml|yml))$' | tr '\n' ' ')"
verbanicm
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.