Fix: Add README notice about non-commercial license for pretrained weights - #66
Conversation
erzel
left a comment
erzel
left a comment
There was a problem hiding this comment.
Apologies for the delay in reviewing.
| @@ -0,0 +1,27 @@ | |||
| from pathlib import Path | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I don't think we need a test for the README file. Can you remove it?
| # Run all tests (requires both JAX and PyTorch installed) | ||
| PYTHONPATH=. python3 -m unittest discover -s tabfm/src/ -p "*_test.py" | ||
|
|
||
| (defaults are 500 features and no fixed row cap), plus `n_estimators` for |
There was a problem hiding this comment.
I think these lines should be outside the '```bash' section.
There was a problem hiding this comment.
Actually, these lines don't seem to belong here. They look like duplicates from the section above.
There was a problem hiding this comment.
Removed the duplicated lines from the Running Tests section. Thanks for catching that!
Removed duplicated README text from the Running Tests section.
| You can run the unit tests directly using Python's `unittest` module: | ||
|
|
||
| ```bash | ||
| # Run all tests (requires both JAX and PyTorch installed) |
There was a problem hiding this comment.
Thanks for removing the duplicate lines. I think these lines should still be here.
There was a problem hiding this comment.
Once you revert this deletion we can merge the CL.
Restore the unittest discovery command while keeping the duplicated README text removed.
Restore the unittest discovery command while keeping the duplicated README text removed.
MayVerse4
left a comment
MayVerse4
left a comment
There was a problem hiding this comment.
Restored the deleted unittest discovery command. Thanks!
2 participants
fix for issue.
Fixes #29