[RVV] more rvv fp16 unary kernels + f32-vcopysign#9693
Open
ken-unger wants to merge 4 commits intogoogle:masterfrom
Open
[RVV] more rvv fp16 unary kernels + f32-vcopysign#9693ken-unger wants to merge 4 commits intogoogle:masterfrom
ken-unger wants to merge 4 commits intogoogle:masterfrom
Conversation
…6-vsqrt, f32-vcopysign
fbarchard
reviewed
Mar 16, 2026
src/f16-vlrelu/rvv.c.in
Outdated
| @@ -0,0 +1,36 @@ | |||
| // Copyright 2024 Imagination Technologies, Inc. | |||
fbarchard
reviewed
Mar 16, 2026
src/f16-vrsqrt/rvv.c.in
Outdated
| @@ -0,0 +1,75 @@ | |||
| // Copyright 2024 Imagination Technologies, inc. | |||
fbarchard
approved these changes
Mar 16, 2026
Collaborator
fbarchard
left a comment
fbarchard
left a comment
There was a problem hiding this comment.
note that f16 tests are crashing on emulator with is a known issue with our emulator at least.
test on real hardware if you can, and we'll likely need to add a build flag to enable/disable fp16.
Contributor
Author
|
@dsharletg could you review and merge when you have some free moments this week. Thank you. Are the rvv fp16 tests now running in the CT environment? Wondering if the qemu update helped there. I haven't seen those issues in my testing. |
dsharlet
approved these changes
Mar 30, 2026
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
-- 4a29295 by Ken Unger <ken.j.unger@gmail.com>: add rvv support for f16-vhswish, f16-vlrelu, f16-vrnd, f16-vrsqrt, f16-vsqrt, f32-vcopysign -- 99f32de by Ken Unger <ken.j.unger@gmail.com>: updated copyright per review comments FUTURE_COPYBARA_INTEGRATE_REVIEW=#9693 from ken-unger:unary-rvv 72587b2 PiperOrigin-RevId: 892124176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added rvv support for additional f16 unary kernels, which are a trivial port from their f32 versions.
Added rvv support for f32-vcopysign
Tested on BPI-F3.
Changes to src/configs/binary-elementwise-config.c and src/configs/unary-elementwise-config.c are the most important to review although all RISCV specific.