Skip to content

Added deprecation warnings for fp16 flags in XNNPACK. #9695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added deprecation warnings for fp16 flags in XNNPACK. #9695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/xnnpack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,14 @@ extern "C" {
/// Allow IEEE FP16 inference in a Runtime.
///
/// Note: this flag hints XNNPACK to consider IEEE FP16 inference, but does not guarantee it.
/// Deprecated, convert the subgraph to FP16 instead.
#define XNN_FLAG_HINT_FP16_INFERENCE 0x00000002

/// Force IEEE FP16 inference in a Runtime, and fail if FP16 inference is not possible.
///
/// Note: this flag guarantees that XNNPACK will use IEEE FP16 inference, or fail to create the Runtime object.
/// Warning: on x86 systems FP16 computations will be emulated at a substantial performance cost.
/// Deprecated, convert the subgraph to FP16 instead.
#define XNN_FLAG_FORCE_FP16_INFERENCE 0x00000004

/// Enable timing of each operator's runtime.
Expand Down
12 changes: 12 additions & 0 deletions src/runtime.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,18 @@ static enum xnn_status create_runtime_impl(
}
}

if (flags & XNN_FLAG_FORCE_FP16_INFERENCE) {
xnn_log_warning(
"XNN_FLAG_FORCE_FP16_INFERENCE is deprecated and will be removed soon: "
"convert your tensors to FP16 instead.");
}

if (flags & XNN_FLAG_HINT_FP16_INFERENCE) {
xnn_log_warning(
"XNN_FLAG_HINT_FP16_INFERENCE is deprecated and will be removed soon: "
"convert your tensors to FP16 instead.");
}

if (flags & XNN_FLAG_SLOW_CONSISTENT_ARITHMETIC) {
xnn_log_warning(
"XNN_FLAG_SLOW_CONSISTENT_ARITHMETIC is enabled: performance will be "
Expand Down
Loading