fix(cli): respect ignore files in adk deploy commands #4187
+230
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
The
adk deploycommands (cloud_run,agent_engine,gke) were not properly respecting.gitignore,.gcloudignore, or.ae_ignorefiles. This caused all files in the source directory, including large or sensitive ones likevenv/,.git/, and.env, to be copied to the temporary staging directory and subsequently uploaded to hosted environments.Solution:
_get_ignore_patterns_funchelper insrc/google/adk/cli/cli_deploy.pythat reads and combines patterns from.gitignore,.gcloudignore, and.ae_ignore.to_cloud_run,to_agent_engine, andto_gketo use this helper as an ignore filter inshutil.copytree.Testing Plan
Unit Tests:
Summary of
pytestresults:Manual End-to-End (E2E) Tests:
Verified the fix by following these steps:
.gitignorefile.shutil.rmtreecleanup in code to inspect./debug_staged_out.agent.pyand.gitignorewere present, butignored_file.txtwas correctly excluded from the staging area.Checklist