This repository was archived by the owner on Mar 1, 2023. It is now read-only.
Add "thenCheck()" to CompiledRepository.#113
Open
maxtroy wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
"thenCheck()" can be used after another 'then' directive, which normally generates the new value of the repository. Using a "thenCheck()" directive, the would-have-been new value becomes a mere "candidate new value", and can be vetoed by the check -- the clause that follows "thenCheck()" can skip the update, end with another value, or even have the flow continue onwards. The test cases use two demo-style repositories that perform a typical task of requesting a keyed item from the in-memory cache, then disk cache, then network, showcasing the real-life use of this new directive.
ghost
assigned
Current coverage is 97.38% (diff: 100%)@@ master #113 diff @@
==========================================
Files 39 39
Lines 1611 1645 +34
Methods 0 0
Messages 0 0
Branches 280 284 +4
==========================================
+ Hits 1568 1602 +34
Misses 13 13
Partials 30 30
|
ghost
requested a review
from 
ghost
approved these changes
Mar 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"thenCheck()" can be used after another 'then' directive, which normally
generates the new value of the repository. Using a "thenCheck()" directive,
the would-have-been new value becomes a mere "candidate new value", and
can be vetoed by the check -- the clause that follows "thenCheck()" can
skip the update, end with another value, or even have the flow continue
onwards.
The test cases use two demo-style repositories that perform a typical task
of requesting a keyed item from the in-memory cache, then disk cache, then
network, showcasing the real-life use of this new directive.