Add support for armembers data source for Mach-O archives#486
Open
rjmansfield wants to merge 2 commits intogoogle:mainfrom
Open
Add support for armembers data source for Mach-O archives#486rjmansfield wants to merge 2 commits intogoogle:mainfrom
rjmansfield wants to merge 2 commits intogoogle:mainfrom
Conversation
Implements the 'archs' data source to break down universal binaries by architecture. This allows users to: - View file size breakdown by architecture: bloaty -d archs - Filter to specific architecture: bloaty -d archs,segments --source-filter=arm64 - Hierarchical breakdown: bloaty -d archs,segments
Note, for archives containing universal binaries, --domain=vm does not currently produce meaningful results because each architecture has its own independent address space, causing address collisions when combined. Use --domain=file instead, for filter to a single architecture with --source-filter=<arch>. Fixes google#153 Fixes google#293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for Darwin/Mach-O archives.
Also, note this PR contains 175026f which has its own PR here: #481 but I'm including it here as it is a dependency and annoying to stack patches. Ideally I can rebase if/when it lands.
Note, for archives containing universal binaries, --domain=vm does not currently produce meaningful results because each architecture has its own independent address space, causing address collisions when combined. So a user should use --domain=file or filter to a single architecture with --source-filter=. This can be addressed if each slice gets it's own vm address space, e.g. using #480