Add support for Apple-Framework builds#1246
Conversation
Signed-off-by: Treata11 <treata11@yahoo.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: Treata11 <treata11@yahoo.com>
|
Addresses issue #1245 |
Signed-off-by: Treata11 <treata11@yahoo.com>
Signed-off-by: Treata11 <treata11@yahoo.com>
|
@eustas, Changes above are sufficient to build for iOS-derived platforms & their simulators. |
| foreach(lib ${BROTLI_LIBRARIES_CORE}) | ||
| set_target_properties(${lib} PROPERTIES | ||
| FRAMEWORK TRUE | ||
| FRAMEWORK_VERSION "${BROTLI_FULL_VERSION}" |
There was a problem hiding this comment.
Thank you this PR.
Please confirm, that FRAMEWORK_VERSION / MACOSX_FRAMEWORK_BUNDLE_VERSION should be semantic (ABI) version. I.e. as of today it will be 2.0.1, not 1.1.0. If not, use existing BROTLI_VERSION (API version)
There was a problem hiding this comment.
Thanks for the review.
Both of the properties are strings that can represent either the ABI or API versions, or even single-letter versioning.
The choice often depends on project conventions or ecosystem requirements
There was a problem hiding this comment.
Let's stick then to API version, because those are human readable...
Greetings,
I introduced the required properties in
CMakeLists.txtto enable cross-compilation for iOS-derived platforms as explained in the CMake documentation.Binaries of
brotlicommon.framework,brotlidec.framework&brotlienc.frameworktargets will be generated in thebuilddirectory with the following commands:It's also worth noting that I included the
BROTLI_PUBLIC_HDRSfiles for the targets above to ensure they are included in the builtframeworkbundles.