Fix Emscripten detection false positives and unsuppressible status me…#1406
Open
mannewalis wants to merge 1 commit intogoogle:masterfrom
Open
Fix Emscripten detection false positives and unsuppressible status me…#1406mannewalis wants to merge 1 commit intogoogle:masterfrom
mannewalis wants to merge 1 commit intogoogle:masterfrom
Conversation
…ssages Issue 1: False positive Emscripten detection The check_c_source_compiles() test incorrectly detected Emscripten when building with non-Emscripten WASM toolchains (e.g., WASI SDK). In cross- compilation scenarios, CMake creates a static library instead of an executable for compile tests. An empty source file (when __EMSCRIPTEN__ is not defined) successfully archives into a static library, causing the test to pass when it should fail. Resolution: Use the EMSCRIPTEN CMake variable set by Emscripten's official toolchain file, which is the recommended detection method. Remove the unreliable check_c_source_compiles() fallback. Issue 2: Unsuppressible status messages The message() calls lacked a type argument, making them always print regardless of CMake's log level settings. Resolution: Add STATUS type to message() calls so they can be suppressed with CMake's --log-level option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ssages
Issue 1: False positive Emscripten detection
The check_c_source_compiles() test incorrectly detected Emscripten when building with non-Emscripten WASM toolchains (e.g., WASI SDK). In cross- compilation scenarios, CMake creates a static library instead of an executable for compile tests. An empty source file (when EMSCRIPTEN is not defined) successfully archives into a static library, causing the test to pass when it should fail.
Resolution: Use the EMSCRIPTEN CMake variable set by Emscripten's official toolchain file, which is the recommended detection method. Remove the unreliable check_c_source_compiles() fallback.
Issue 2: Unsuppressible status messages
The message() calls lacked a type argument, making them always print regardless of CMake's log level settings.
Resolution: Add STATUS type to message() calls so they can be suppressed with CMake's --log-level option.