Skip to content

Fix Typescript 6.0.2 compilation errors#1183

Merged
tushuhei merged 3 commits intomainfrom
dependabot/npm_and_yarn/javascript/typescript-6.0.2-7701969148889149576
Mar 28, 2026
Merged

Fix Typescript 6.0.2 compilation errors#1183
tushuhei merged 3 commits intomainfrom
dependabot/npm_and_yarn/javascript/typescript-6.0.2-7701969148889149576

Conversation

@tushuhei
Copy link
Copy Markdown
Member

Fixes CI compilation failures after dependabot PR #1182 bumped typescript to 6.0.2.


PR created automatically by Jules for task 7701969148889149576 started by @tushuhei

Adds missing types and explicit type declarations required by stricter TypeScript 6.0 checking. Includes `node` types, updates compiler `lib`, and types the mapped structures in `parser.ts` to fix `flatMap` implicit `any` errors. Removes unused type imports.

Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules bot and others added 2 commits March 26, 2026 13:14
- Update biome.json schema from 2.4.4 to 2.4.8 to match the installed biome version
- Run `biome check --write .` to fix formatting in src/parser.ts

Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
- Change `moduleResolution` to `"bundler"` instead of deprecated `"node"`.
- Explicitly type implicit `any` callbacks that throw under TypeScript 6.0's stricter analysis.
- Substitute the deprecated `ExecFileException` import with `Error` in `test_cli.ts`.
- Update `parseFromString` signature for `linkedom` DOMParser compatibility.
- Update `biome.json` schema version to 2.4.8 to fix mismatch.
- Fix string wrapping for `parser.ts` formatting using Biome.

Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
@tushuhei tushuhei requested a review from kojiishi March 26, 2026 22:45
Copy link
Copy Markdown
Collaborator

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tushuhei tushuhei merged commit f28b135 into main Mar 28, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants