Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

# 8.12.4

- Reduce use of dynamic calls in generated `operator==` when there are
functions: only use dynamic calls if the class also has type parameters.

# 8.12.3

- Require `analyzer ^10.0.0`, stop using removed and deprecated methods from
Expand Down
4 changes: 2 additions & 2 deletions benchmark/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: benchmark
version: 8.12.3
version: 8.12.4
publish_to: none
description: >
Benchmark, not for publishing.
Expand All @@ -14,7 +14,7 @@ dependencies:

dev_dependencies:
build_runner: '>=1.0.0 <3.0.0'
built_value_generator: ^8.12.3
built_value_generator: ^8.12.4
pedantic: ^1.4.0
quiver: '>=0.21.0 <4.0.0'
test: ^1.0.0
2 changes: 1 addition & 1 deletion built_value/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: built_value
version: 8.12.3
version: 8.12.4
description: >
Value types with builders, Dart classes as enums, and serialization.
This library is the runtime dependency.
Expand Down
2 changes: 1 addition & 1 deletion built_value_generator/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: built_value_generator
version: 8.12.3
version: 8.12.4
description: >
Value types with builders, Dart classes as enums, and serialization.
This library is the dev dependency.
Expand Down
12 changes: 4 additions & 8 deletions built_value_generator/test/built_value_generator_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -882,33 +882,29 @@ abstract class NestedValue implements Built<NestedValue, NestedValueBuilder> {

test('uses dynamic for equality check on function fields with generics',
() async {
expect(
await generate('''library value;
expect(await generate('''library value;
import 'package:built_value/built_value.dart';
part 'value.g.dart';
abstract class Value<T> implements Built<Value<T>, ValueBuilder<T>> {
Value._();
factory Value([void Function(ValueBuilder<T>) updates]) = _\$Value<T>;
void Function(T) get callback;
}
'''),
contains(r'final dynamic _$dynamicOther = other;'));
'''), contains(r'final dynamic _$dynamicOther = other;'));
});

test(
'does not use dynamic for equality check on function fields without generics',
() async {
expect(
await generate('''library value;
expect(await generate('''library value;
import 'package:built_value/built_value.dart';
part 'value.g.dart';
abstract class Value implements Built<Value, ValueBuilder> {
Value._();
factory Value([void Function(ValueBuilder) updates]) = _\$Value;
void Function(int) get callback;
}
'''),
isNot(contains(r'dynamicOther')));
'''), isNot(contains(r'dynamicOther')));
});

test('cleans generated class names for private classes', () async {
Expand Down
4 changes: 2 additions & 2 deletions built_value_test/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: built_value_test
version: 8.12.3
version: 8.12.4
description: >
Value types with builders, Dart classes as enums, and serialization.
This library provides test support.
Expand All @@ -21,7 +21,7 @@ dependencies:
quiver: '>=0.21.0 <4.0.0'

dev_dependencies:
built_value_generator: ^8.12.3
built_value_generator: ^8.12.4
build_runner: '>=1.0.0 <3.0.0'
pedantic: ^1.4.0
test: ^1.0.0
4 changes: 2 additions & 2 deletions chat_example/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: chat_example
version: 8.12.3
version: 8.12.4
publish_to: none
description: >
Just an example, not for publishing.
Expand All @@ -21,6 +21,6 @@ dev_dependencies:
build_runner: any
build_test: any
build_web_compilers: any
built_value_generator: ^8.12.3
built_value_generator: ^8.12.4
pedantic: ^1.4.0
test: ^1.0.0
4 changes: 2 additions & 2 deletions end_to_end_test/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: end_to_end_test
version: 8.12.3
version: 8.12.4
publish_to: none
description: >
Tests, not for publishing.
Expand All @@ -15,7 +15,7 @@ dependencies:
dev_dependencies:
build: '>=3.1.0 <5.0.0'
build_runner: '>=2.5.0 <3.0.0'
built_value_generator: ^8.12.3
built_value_generator: ^8.12.4
fixnum: ^1.0.0
pedantic: ^1.4.0
quiver: '>=0.21.0 <4.0.0'
Expand Down
2 changes: 1 addition & 1 deletion example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies:

dev_dependencies:
build_runner: '>=1.0.0 <3.0.0'
built_value_generator: ^8.12.3
built_value_generator: ^8.12.4
pedantic: ^1.4.0
quiver: '>=0.21.0 <4.0.0'
test: ^1.0.0
Loading