Skip to content
This repository was archived by the owner on Apr 17, 2026. It is now read-only.

Add Jupyter plugin support to caliban [draft]#19

Draft
sritchie wants to merge 1 commit into
mainfrom
sritchie/custom_app_dir
Draft

Add Jupyter plugin support to caliban [draft]#19
sritchie wants to merge 1 commit into
mainfrom
sritchie/custom_app_dir

Conversation

@sritchie

Copy link
Copy Markdown
Contributor

This PR is here to begin figuring out how to do this for jupyter and jupyterlab.

@codecov

codecov Bot commented Jun 19, 2020

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.44%. Comparing base (0bd5667) to head (adbd647).
Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
caliban/platform/notebook.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   50.60%   50.44%   -0.16%     
==========================================
  Files          28       28              
  Lines        2897     2898       +1     
==========================================
- Hits         1466     1462       -4     
- Misses       1431     1436       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sritchie sritchie force-pushed the sritchie/custom_app_dir branch from c63be16 to adbd647 Compare July 24, 2020 16:54
@sritchie

Copy link
Copy Markdown
Contributor Author

I've looked more into this, and it won't work to do what I've done in the PR! That's because you need to run jupter lab build after you change the directory.

I think we'll need to explicitly support this by adding a jupyter_plugins list to .calibanconfig, and then do this to get them installed without blowing up the base image:

jupyterlab/jupyterlab#4930

If we want to be REALLY pro, we can do a multistage build for this step. That is probably the right approach.

@sritchie sritchie changed the title Store Jupyter plugins in home directory [draft] Add Jupyter plugin support to caliban [draft] Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant