Add Deep Learning VM (DLVM) images as a base image option for Caliban. by sagravat · Pull Request #20 · google/caliban

sagravat · 2020-06-19T18:17:52Z

This contribution enables Deep Learning VM (DLVM) images from the Google Cloud AI Platform to be used as base images for execution in local, cloud, shell, and notebook modes. The notebook mode includes a Jupyterlab extension widget that allows the user to directly submit the notebook for training on the AI Platform with configurable hardware accelerators like GPUs and TPUs.

…ion.

…elp function to list the DLVM types.

…e-auth release issue.

…d for scheduler.

codecov · 2020-06-19T18:20:10Z

Codecov Report

❌ Patch coverage is 10.16949% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.97%. Comparing base (a912775) to head (3a417e9).
⚠️ Report is 72 commits behind head on main.

Files with missing lines	Patch %	Lines
caliban/docker.py	7.14%	39 Missing ⚠️
caliban/cloud/core.py	20.00%	4 Missing ⚠️
caliban/main.py	0.00%	4 Missing ⚠️
caliban/config.py	40.00%	3 Missing ⚠️
caliban/history/utils.py	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   45.67%   44.97%   -0.70%     
==========================================
  Files          17       17              
  Lines        2728     2777      +49     
==========================================
+ Hits         1246     1249       +3     
- Misses       1482     1528      +46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sritchie

@sagravat , this is great! I want to see if we can separate the logic here a bit more. Ideally, we would be able to reuse the existing run_interactive and run_notebook commands (I think that's the names), and make this PR into TWO changes.

The first is the --base_image support, and the second is the GCP notebook submitter.

The second is the GCP scheduler, which I think will work without the DLVM base images.

I'm having trouble parsing the new entrypoint that the second change requires. Is it really different than how we launch jupyterlab normally? If not, I wonder if we could actually enable this by making it easier for folks to install ANY jupyterlab extension.

Happy to chat more. Take a look and let me know if these notes make sense.

sritchie · 2020-06-23T15:01:39Z

+      "--dlvm",
+      help="DLVM base image type. Must be one of  "
+           "{}".format(dlvm_types) + ". If supplied, "
+      "Caliban will skip the build and push steps and use this image tag.")


hey, I'm going to add comments as I read, so this may be clear later! Naively I would have assumed that the DLVM would be a base image, and that you could still install dependencies on top, right? If that is true, can we call this argument --base_image?

Right now, --image_id removes any requirement.txt installation; it's truly a flag to skip any build, including even getting your code into the image.

Really, the syntax should be caliban run e2a4af785bdb...

sritchie · 2020-06-23T15:03:19Z



-def generate_image_tag(project_id, docker_args, dry_run: bool = False):
+def generate_image_tag(project_id, docker_args, dlvm: str = None, dry_run: bool = False):


if we call it --base_image we can add that key to the generate_docker_args function here: https://github.com/google/caliban/blob/master/caliban/cli.py#L536

sritchie · 2020-06-23T15:05:26Z

+  return _dlvm_config(job_mode).get(dlvm_arg)
+
+
+def _dlvm_config(job_mode: JobMode) -> Dict[str, str]:


nice, this is good. I think I see now why you have --dlvm vs --base_image. What we COULD do is have a prefix for --base_image, something like --base_image dlvm:pytorch, that would force a lookup here. That would let this feature give us general base images too.

sritchie · 2020-06-23T15:06:21Z

-  return """
+  if not dlvm:
+    return """
 RUN pip install {}{}


oh, wait, good catch that we need up date this pip too! I can do that separately.

We have this --lab flag. I'm thinking that we should only do this special installation if --lab is specified. If not, even with a dlvm base image, we should just install normal jupyter. wdyt?

sritchie · 2020-06-23T15:07:17Z

 """.format(library, version_suffix)
+  else:
+    return """
+RUN /opt/conda/bin/pip install \


does this only work on the deep learning VMs? and does it work on ALL the deep learning VMs?

If it works without the dlvms, maybe it needs its own flag.

sritchie · 2020-06-23T15:10:15Z

  if base_image_fn is None:
    base_image_fn = base_image_id

-  base_image = base_image_fn(job_mode)


Can you instead pass

base_image_fn = lambda job_mode: _dlvm_id(job_mode, dlvm)

Then we can keep to the API.

sritchie · 2020-06-23T15:13:35Z



-def _notebook_entries(lab: bool = False, version: Optional[str] = None) -> str:
+def _notebook_entries(lab: bool = False, version: Optional[str] = None, dlvm: bool = False) -> str:


Can we make this flag called scheduler instead? I think it doesn't depend on dlvm and COULD be a separate flag.

sritchie · 2020-06-23T15:14:18Z

+  if inject_notebook.value != 'none':
+    install_lab = inject_notebook == NotebookInstall.lab
+    if dlvm is None:
+        dockerfile += _notebook_entries(lab=install_lab, version=jupyter_version, dlvm=False)


how about remove the if/else and make the line

dockerfile += _notebook_entries(lab=install_lab, version=jupyter_version, dlvm=bool(dlvm))

sritchie · 2020-06-23T15:15:17Z

+
+  dockerfile += """
+
+USER {uid}:{gid}


nice! Now that we're on python 3.6, we can actually make this

dockerfile += f""" USER {uid}:{gid} """

using f-strings.

sagravat added 14 commits June 14, 2020 22:32

initial commit for DLVM feature for notebook, local, and cloud execut…

e63178f

…ion.

fixed issue for DLVM notebook scheduler extension installation.

ac8eb97

Updated entrypoint for interactive mode for regular and DLVM mode.

80ca15b

Implemented shell mode for DLVM.

c8e1582

Code cleanup to move functionality from build_dlvm_image to build_image

20c34ef

Fixed issue with run_interactive toggling between shell and DLVM modes.

0c96fc8

Cleanup run_interactive and scheduler extension build.

aecb17e

Set minimize to False for jupyter lab build and code cleanup.

77d0f5a

Added DLVM config map from Google Container Registry and set up the h…

e4cba55

…elp function to list the DLVM types.

Update required google api packages to specific versions due to googl…

6ba10e0

…e-auth release issue.

Sorted DLVM arg types returned to help command.

baf0aff

Cleanup and update setup.py with upstream versions.

b1cb30e

Merge remote-tracking branch 'upstream/master'. Fixed jupyterlab buil…

3abf664

…d for scheduler.

Set python to 3.6

3a417e9

sagravat changed the title ~~Added Deep Learning VM (DLVM) images as a base image option for Caliban.~~ Add Deep Learning VM (DLVM) images as a base image option for Caliban. Jun 20, 2020

sritchie suggested changes Jun 23, 2020

View reviewed changes

This was referenced Jul 15, 2020

Add Schema for Calibanconfig #37

Merged

Custom base image support in calibanconfig #39

Merged

sritchie mentioned this pull request Jul 29, 2020

A way to provide my own docker image? #61

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Deep Learning VM (DLVM) images as a base image option for Caliban.#20

Add Deep Learning VM (DLVM) images as a base image option for Caliban.#20
sagravat wants to merge 14 commits into
google:mainfrom
sagravat:master

sagravat commented Jun 19, 2020

Uh oh!

codecov Bot commented Jun 19, 2020 •

edited

Loading

Uh oh!

sritchie left a comment

Uh oh!

sritchie Jun 23, 2020

Uh oh!

sritchie Jun 23, 2020

Uh oh!

sritchie Jun 23, 2020

Uh oh!

sritchie Jun 23, 2020

Uh oh!

sritchie Jun 23, 2020

Uh oh!

sritchie Jun 23, 2020

Uh oh!

sritchie Jun 23, 2020

Uh oh!

sritchie Jun 23, 2020

Uh oh!

sritchie Jun 23, 2020

Uh oh!

sritchie Jun 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		def generate_image_tag(project_id, docker_args, dry_run: bool = False):
		def generate_image_tag(project_id, docker_args, dlvm: str = None, dry_run: bool = False):

		return _dlvm_config(job_mode).get(dlvm_arg)


		def _dlvm_config(job_mode: JobMode) -> Dict[str, str]:



		def _notebook_entries(lab: bool = False, version: Optional[str] = None) -> str:
		def _notebook_entries(lab: bool = False, version: Optional[str] = None, dlvm: bool = False) -> str:

Conversation

sagravat commented Jun 19, 2020

Uh oh!

codecov Bot commented Jun 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sritchie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jun 19, 2020 •

edited

Loading