Skip to content
This repository was archived by the owner on Apr 17, 2026. It is now read-only.

fix for issue #40#41

Merged
sritchie merged 1 commit into
masterfrom
aslone/issue_40_fix
Jul 15, 2020
Merged

fix for issue #40#41
sritchie merged 1 commit into
masterfrom
aslone/issue_40_fix

Conversation

@ajslone

@ajslone ajslone commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

I think this is a sufficient change for issue #40, but please have a look.

@ajslone ajslone requested a review from sritchie July 15, 2020 23:03
@codecov

codecov Bot commented Jul 15, 2020

Copy link
Copy Markdown

Codecov Report

Merging #41 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   49.47%   49.44%   -0.04%     
==========================================
  Files          28       28              
  Lines        2872     2872              
==========================================
- Hits         1421     1420       -1     
- Misses       1451     1452       +1     
Impacted Files Coverage Δ
caliban/config/__init__.py 71.92% <100.00%> (ø)
caliban/platform/gke/util.py 70.76% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850a049...fe9d857. Read the comment docs.

@eschnett

Copy link
Copy Markdown
Contributor

Thanks!

@sritchie

Copy link
Copy Markdown
Contributor

Yes! Sorry to you both, I thought I had the default handling down a little better. I had a nice clean fix in #39 - now that @eschnett is working on his PR (thank you!!!) I need to keep the house in better order :)

@sritchie sritchie merged commit f641c9d into master Jul 15, 2020
@ajslone ajslone deleted the aslone/issue_40_fix branch August 10, 2020 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants