Add project and zone to CreateDiskFromSnapshot#539
Open
Fryyyyy wants to merge 8 commits intogoogle:mainfrom
Open
Add project and zone to CreateDiskFromSnapshot#539Fryyyyy wants to merge 8 commits intogoogle:mainfrom
Fryyyyy wants to merge 8 commits intogoogle:mainfrom
Conversation
Updated `CreateDiskFromSnapshot` in the GCP compute provider to allow users to specify an optional `dest_project` and `dest_zone` when creating a disk from a snapshot. The method defaults to the instance's `project_id` and `default_zone` if these are not provided. Included unit tests to verify behavior.
Updated `CreateDiskFromSnapshot` in the GCP compute provider to allow users to specify an optional `dest_project` and `dest_zone` when creating a disk from a snapshot. The method defaults to the instance's `project_id` and `default_zone` if these are not provided. Included unit tests to verify behavior. Fixes BlockOperation parameter passing.
…5322369123445590457 feat(gcp): Add optional destination project and zone to CreateDiskFromSnapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow destination project and zone to be overriden when creating a disk from a snapshot