Changed the listener_ to be called with the abstract model interface.#4
Open
AlexRNau wants to merge 2 commits intogoogle:masterfrom
Open
Changed the listener_ to be called with the abstract model interface.#4AlexRNau wants to merge 2 commits intogoogle:masterfrom
AlexRNau wants to merge 2 commits intogoogle:masterfrom
Conversation
…s the "this" value instead of just passing in the model. This will allow users to more safely edit the abstract model in callback listeners.
…the abstractModelInterface_!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it safer for users to mess with the model in callbacks. Let me know if you want more tests.