[codex] fix initial measurement sigma#32
Draft
vvv214 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR fixes the local AIM/MST direct-call path for initial one-way measurements.
accounting.zcdp_gaussian_sigma(...)common.measure_marginals_with_noiseWhy
common.measure_marginals_with_noiseinterpretsgdp_sigmaas a Gaussian standard deviation. The direct paths inAIMMechanismandMSTMechanismwere passing a zCDP budget share directly wheninitial_measurementswas not supplied.Validation
python3 -m py_compile dpsynth/discrete_mechanisms/aim.py dpsynth/discrete_mechanisms/mst.py tests/discrete_mechanisms/aim_test.py tests/discrete_mechanisms/mst_test.pyrg -n "gdp_sigma=.*zcdp_rho \\*|gdp_sigma=self\\.zcdp_rho \\*|gdp_sigma=zcdp_rho \\*" dpsynth/discrete_mechanisms tests/discrete_mechanismsreturns no matchesFull pytest was not run locally because this checkout's test dependencies (
pipeline_dp,mbi,dp_accounting, Beam/JAX stack) are not installed in the current environment, and the local Python is 3.14 while the project declares<3.14.