Open
Conversation
joelmacx
reviewed
Mar 17, 2026
Collaborator
joelmacx
left a comment
There was a problem hiding this comment.
I like these changes, just a bit of cleanup to do 👍
Did we validate in at least Pro Tools and Reaper DAWs as well?
Collaborator
There was a problem hiding this comment.
I'm curious why we're using milliseconds instead of sample rate and sample count directly? From the UI the user should configure the time in seconds/milliseconds but on the backend this should likely be sample count to be as accurate as possible, no? Curious to hear some more thoughts here
Contributor
Author
There was a problem hiding this comment.
That will give even better precision. The issue was that seconds were stored as ints, and we were losing frames on export. Milliseconds fixed this, but moving to samples will be cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When setting time values in the export screen, there was a previous bug in which leaving the menu and then returning to it cleared the export timing values. Furthermore, export timing was truncated, losing timing precision.
Changes
Validation and Acceptance Criteria
Briefly describe how this PR meets any acceptance criteria defined in the linked issue.
-All tests are passing