This repository was archived by the owner on Dec 1, 2022. It is now read-only.
Open
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
@googlebot I signed it ! Well, not directly, but I work for Red Hat, and there is a CLA for Red Hat / Google in place. My understanding is that not just the Kubernetes work is covered by that CLA |
Author
|
@googlebot ping |
|
Wouldn't it be better to be able to pass a user defined url to the Sender() constructor ? |
|
See #168. FCM could be made the default endpoint though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done to match latest Server endpoint changes, discussed in https://developers.google.com/cloud-messaging/android/android-migrate-fcm#update_server_endpoints