Exit immediately when reading a repo fails#191
Open
r0mflip wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
Collaborator
nguyen-phillip
left a comment
nguyen-phillip
left a comment
There was a problem hiding this comment.
Wouldn't this mean that a single bad user-configured repo would block all Googet operations even though all of the managed repos were available? This seems a bit severe. I'd be less worried about a change that allowed marking certain repos as critical in the configuration and then failing only for the critical repos.
| rf, err := d.unmarshalRepoPackages(ctx, r, cacheDir, cacheLife) | ||
| if err != nil { | ||
| logger.Errorf("error reading repo %q: %v", r, err) | ||
| errs = multierr.Append(errs, fmt.Errorf("error reading repo %q: %w", r, err)) |
Collaborator
There was a problem hiding this comment.
Use errors.Join from the standard library instead of multierr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A package information must be retrieved from all the repos to determine priorities and figure out right installation candidate avoiding package overrides from unintended repos.