Skip to content

Add traceback to exceptions raised in prefetch worker. #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add traceback to exceptions raised in prefetch worker. #1258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions grain/_src/python/dataset/transformations/process_prefetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from multiprocessing import util
import queue
import time
import traceback
from typing import Any, TypeVar
import weakref

Expand Down Expand Up @@ -238,6 +239,7 @@ def _put_dataset_elements_in_buffer(
try:
element = it.__next__()
except Exception as e: # pylint: disable=broad-except
e.add_note("\n".join(traceback.format_exception(e)))
grain_queue.add_element_to_queue( # pytype: disable=wrong-arg-types
(None, None, None, e), buffer, should_stop.is_set
)
Expand All @@ -262,6 +264,8 @@ def _put_dataset_elements_in_buffer(
except Exception as e: # pylint: disable=broad-except
_clear_queue_and_maybe_unlink_shm(buffer)
_clear_queue_and_maybe_unlink_shm(set_state_queue)
e.add_note("\n".join(traceback.format_exception(e)))

grain_queue.add_element_to_queue( # pytype: disable=wrong-arg-types
(None, None, None, e), buffer, should_stop.is_set
)
Expand Down
Loading