Move JobDialogComponent to shared and rename it to DialogComponent#2562
Merged
rfontanarosa merged 2 commits intoJul 17, 2026
Merged
Conversation
rfontanarosa
commented
Jul 16, 2026
Collaborator
- New location: web/src/app/components/shared/dialog/ (dialog.component.*, dialog.module.ts), selector renamed job-dialog -> ground-dialog
- Renamed class JobDialogComponent -> DialogComponent and module JobDialogModule -> DialogModule
- Updated all importers (edit-survey, edit-details, header, dirty-check guard, survey-list, loi-editor, task-form, and their specs) to import from app/components/shared/dialog/dialog.component
- Kept the exported DialogType / DialogData / dialogConfigs and the JOB_NAME_FIELD_ID constant unchanged to keep the diff focused
…ared/, and rename JobDialogComponent to DialogComponent
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2562 +/- ##
==========================================
+ Coverage 62.54% 62.57% +0.03%
==========================================
Files 119 119
Lines 2878 2878
Branches 432 432
==========================================
+ Hits 1800 1801 +1
+ Misses 1016 1015 -1
Partials 62 62 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gino-m
approved these changes
Jul 17, 2026
rfontanarosa
deleted the
rfontanarosa/refactor-move-job-dialog-to-shared-dialog
branch
July 17, 2026 11:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.