Skip to content

Move JobDialogComponent to shared and rename it to DialogComponent#2562

Merged
rfontanarosa merged 2 commits into
masterfrom
rfontanarosa/refactor-move-job-dialog-to-shared-dialog
Jul 17, 2026
Merged

Move JobDialogComponent to shared and rename it to DialogComponent#2562
rfontanarosa merged 2 commits into
masterfrom
rfontanarosa/refactor-move-job-dialog-to-shared-dialog

Conversation

@rfontanarosa

Copy link
Copy Markdown
Collaborator
  • New location: web/src/app/components/shared/dialog/ (dialog.component.*, dialog.module.ts), selector renamed job-dialog -> ground-dialog
  • Renamed class JobDialogComponent -> DialogComponent and module JobDialogModule -> DialogModule
  • Updated all importers (edit-survey, edit-details, header, dirty-check guard, survey-list, loi-editor, task-form, and their specs) to import from app/components/shared/dialog/dialog.component
  • Kept the exported DialogType / DialogData / dialogConfigs and the JOB_NAME_FIELD_ID constant unchanged to keep the diff focused

@rfontanarosa
rfontanarosa requested a review from gino-m July 16, 2026 13:56
@rfontanarosa rfontanarosa self-assigned this Jul 16, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.57%. Comparing base (ddb1502) to head (948bce8).

Files with missing lines Patch % Lines
...c/app/components/shared/header/header.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2562      +/-   ##
==========================================
+ Coverage   62.54%   62.57%   +0.03%     
==========================================
  Files         119      119              
  Lines        2878     2878              
  Branches      432      432              
==========================================
+ Hits         1800     1801       +1     
+ Misses       1016     1015       -1     
  Partials       62       62              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rfontanarosa
rfontanarosa merged commit 4aea145 into master Jul 17, 2026
14 checks passed
@rfontanarosa
rfontanarosa deleted the rfontanarosa/refactor-move-job-dialog-to-shared-dialog branch July 17, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants