Skip to content

Issue #1909 - remove deprecated Unsafe usage#1932

Open
kamilkrzywanski wants to merge 4 commits into
google:masterfrom
kamilkrzywanski:issue_1909
Open

Issue #1909 - remove deprecated Unsafe usage#1932
kamilkrzywanski wants to merge 4 commits into
google:masterfrom
kamilkrzywanski:issue_1909

Conversation

@kamilkrzywanski

@kamilkrzywanski kamilkrzywanski commented Apr 18, 2026

Copy link
Copy Markdown

(requires jdk15+)
it will also resolve issue #1901

@google-cla

google-cla Bot commented Apr 18, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

(requires at least jdk15)

Signed-off-by: Kamil Krzywanski <kamilkrzywanski01@gmail.com>
@GedMarc

GedMarc commented Apr 19, 2026

Copy link
Copy Markdown

@kamilkrzywanski

Copy link
Copy Markdown
Author

@GedMarc Where can I find parent pom to run this project?
UnsafeClassDefiner in my code is renamed to LookupClassDefiner, AnonymousClassDefiner is dead and removed since Unsafe::defineAnonymousClass is removed

@MarcMagonMNS

Copy link
Copy Markdown

Hmm snapshots don't go to central anymore - I'm pushing through RC6, central is a nightmare will ping when up.
I use the github packages

<repository>
    <id>guicedee-github</id>
    <url>https://maven.pkg.github.com/GuicedEE/</url>
    <snapshots>
        <enabled>true</enabled>
    </snapshots>
</repository>

Those are actually better resolutions than I had, I used the private lookups but it looks cleaner

@kamilkrzywanski

Copy link
Copy Markdown
Author

The solution based on https://github.com/GuicedEE/Services/tree/master/Google/guice-core
will most likely not pass the tests.

@GedMarc

GedMarc commented Apr 25, 2026

Copy link
Copy Markdown

@kamilkrzywanski Could you try with -RC9 which is in central now

<dependency>
            <groupId>com.guicedee.modules.services</groupId>
            <artifactId>guice</artifactId>
            <version>2.0.0-RC9</version>
        </dependency>

@kamilkrzywanski

Copy link
Copy Markdown
Author

@GedMarc created PR: GuicedEE/Services#74

(requires at least jdk15)

Signed-off-by: Kamil Krzywanski <kamilkrzywanski01@gmail.com>
@kamilkrzywanski

Copy link
Copy Markdown
Author

@GedMarc Added copilot sugestions about HiddenClassDefiner class

(requires at least jdk15)

Signed-off-by: Kamil Krzywanski <kamilkrzywanski01@gmail.com>
(requires at least jdk15)

Signed-off-by: Kamil Krzywanski <kamilkrzywanski01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants