add contrib/dot benchmarks#3067
Open
mytsvy wants to merge 1 commit into
Open
Conversation
jan-wassenberg
requested changes
Jun 2, 2026
Member
jan-wassenberg
left a comment
jan-wassenberg
left a comment
There was a problem hiding this comment.
Thanks for adding :) Two minor suggestions:
| FillArrays(a.get(), b.get(), max_count, rng); | ||
|
|
||
| const size_t N = Lanes(d); | ||
| (void)N; |
Member
There was a problem hiding this comment.
Let's use N when passing to TypeName, then no need for the void cast?
| static_cast<double>(count) * (sizeof(TA) + sizeof(TB)); | ||
|
|
||
| const size_t num_results_generic = MeasureClosure( | ||
| [&](FuncInput) { |
Member
There was a problem hiding this comment.
To ensure the computation isn't elided, can we make Compute() depend on the FuncInput? For example, we could set input to count * Unpredictable1(), then pass the FuncInput as the count arg to Compute?
Member
|
Also looks like we have some check failures: signed/unsigned casts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a dot product benchmark that measures both generic and kMultipleOfVector paths side-by-side across common sizes.
Dot::Compute has assumption-dependent fast paths; benchmarking only the generic path hides key perf behavior. This adds an explicit comparison in one run.
Test: