Open
Conversation
Contributor
Author
|
@hfmehmed Would you mind taking a look? |
Goooler
force-pushed
the
workflows
branch
4 times, most recently
from
98c4dcb to
21aedc7
Compare
Goooler
commented
Nov 5, 2025
Comment on lines
-53
to
-65
| - name: Cache Gradle Cache | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ~/.gradle/caches | ||
| key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle.kts') }}-${{ hashFiles('**/gradle.properties') }} | ||
| # An ordered list of keys to use for restoring the cache if no cache hit occurred for key | ||
| restore-keys: | | ||
| ${{ runner.os }}-gradle- | ||
| - name: Cache gradle wrapper | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ~/.gradle/wrapper | ||
| key: ${{ runner.os }}-gradle-wrapper-${{ hashFiles('gradle/wrapper/gradle-wrapper.properties') }} |
Contributor
Author
There was a problem hiding this comment.
These cache steps do not work correctly, they should be run on the default branch only.
Goooler
force-pushed
the
workflows
branch
2 times, most recently
from
e66619d to
46240a2
Compare
Collaborator
|
I took a look at this and most changes look good in general although it is difficult for me to confirm that there will no unexpected regressions or behaviour changes after this. Would you mind splitting the PRs a bit, e.g updating JDK separately, updating the github action versions to v5, setting up the gradle cache etc. It will make it easier to review as well as after each change we can see if there is unexpected things happening. |
Contributor
Author
|
The workflows are so simple that I don’t expect any regressions or difficulties in understanding. |
- Bump actions, old ones are deprecated. - Cache Gradle stuff via `gradle/actions/setup-gradle`. - Replace `gw check` with `gw build`, which includes check and the other tasks. - Replace build reports uploading with Gradle build scans published by the Develocity plugins. - Disables redundant jobs for the forked repositories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gradle/actions/setup-gradle.gw checkwithgw build, which includes check and the other tasks.