Open
Conversation
jaschdoc
force-pushed
the
bump-java-version
branch
from
c5ed051 to
3e1ed11
Compare
Collaborator
|
It shouldn't affect user consuming ksp via gradle plugin but it will affect people depending on the ksp artifacts directly to build on top of them (basically it forces them to upgrade to jdk 17 as well). Actually technically for gradle plugin consumers it also requires them to run gradle daemon with jdk 17 toolchain i believe - so it does affect them too in some way i guess but it seems less severe. |
jaschdoc
force-pushed
the
bump-java-version
branch
from
3e1ed11 to
502231f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can we do this or could there be downstream problems from this? Upgrading would allows us to upgrade some dependencies such as JUnit and caffeine.