Expose block encoding parameters in verifier specs - #159
Open
mysteryon88 wants to merge 4 commits into
Open
Conversation
Include block_enc_hash and block_enc_sig from kZkSpecs in the JSON response returned by the verifier's /specs endpoint. Add regression coverage for both required fields.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mysteryon88
requested review from
abhvious,
ask77nl and
matteo-frigo
as code owners
July 23, 2026 08:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
block_enc_hashandblock_enc_sigto the verifier'sZKSpecJSON responsekZkSpecssource of truthWhy
The Longfellow ZK system specification documents
block_enc_hashandblock_enc_sigas required parameters forZkSystemSpecand OpenID4VPzk_system_type.The reference verifier's
/specsendpoint currently omits these fields,even though their values are already available in
kZkSpecs. As a result,relying parties cannot construct a complete ZK system specification from
the endpoint and would have to hardcode the parameters or parse the C++
source.
This change makes
/specsconsistent with the documented format and keepskZkSpecsas the single source of truth. The response change is additive.This is a follow-up to #95, which documented the required parameters.