Conversation
- move to TFLite 2.16.2 - bump deps' versions accordingly (based on TF bazel workspace) - support building with custom sysroot - support pthreadpool self-build The latter currently requires a hack whereby it gets to be installed in the sysroot. We need to patch pthreadpool to support `find_packge`.
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Seems reasonable enough to me.
We don't need to patch pthreadpool upstream to support find_package, we just need to add a find module, probably on the tensorflow side. There is support for downloading/specifying the pthreadpool source natively within the tensorflow build, but I remember running into issues the last time I hacked on the build. It should probably be converted to a find module and use an external build just like everything else rather than hackily using CMake to build it as part of the TFLite build if not specifying to use the system dep.
| # pthreadpool | ||
| # NOTE: currently a hack, because pthreadpool doesn't support find_package. | ||
| # we install in the default install dir, which really means the script must be run | ||
| # under sudo. Works for buildbots. Not ideal elsewhere. |
There was a problem hiding this comment.
This would need doc updates probably?
I'm wondering if we should just install it to the sysroot if that's specified, but otherwise default to the system dependency.
2 participants
The latter currently requires a hack whereby it gets to be installed
in the sysroot. We need to patch pthreadpool to support
find_packge.