Skip to content

Update custom-select.js #5170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegoteran merged 1 commit into from
Jun 4, 2026
Merged

Update custom-select.js #5170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions packages/modelviewer.dev/examples/scenegraph/custom-select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ class CustomSelect extends HTMLElement {
.panel.open {
display: block;
}
.panel.upward {
top: auto;
bottom: calc(100% + 4px);
box-shadow: 0 -4px 12px rgba(0, 0, 0, 0.1);
}
ul {
list-style: none;
padding: 4px 0;
Expand Down Expand Up @@ -198,9 +203,21 @@ class CustomSelect extends HTMLElement {

open() {
this._isOpen = true;
this.shadowRoot.getElementById('btn').classList.add('open');
this.shadowRoot.getElementById('panel').classList.add('open');

const btn = this.shadowRoot.getElementById('btn');
const panel = this.shadowRoot.getElementById('panel');
btn.classList.add('open');
panel.classList.add('open');

const rect = btn.getBoundingClientRect();
const spaceBelow = window.innerHeight - rect.bottom;
const panelHeight = Math.min(panel.scrollHeight, 200);

if (spaceBelow < panelHeight + 10 && rect.top > panelHeight) {
panel.classList.add('upward');
} else {
panel.classList.remove('upward');
}

const selectedItem = this.shadowRoot.querySelector('li.selected');
if (selectedItem) {
setTimeout(() => selectedItem.scrollIntoView({ block: 'nearest' }), 50);
Expand All @@ -210,7 +227,9 @@ class CustomSelect extends HTMLElement {
close() {
this._isOpen = false;
this.shadowRoot.getElementById('btn').classList.remove('open');
this.shadowRoot.getElementById('panel').classList.remove('open');
const panel = this.shadowRoot.getElementById('panel');
panel.classList.remove('open');
panel.classList.remove('upward');
}

sync() {
Expand Down
Loading