Fix f-string debug format parsing for Python 3.8+ ({expr=})#118
Open
aryanyk wants to merge 1 commit intogoogle:masterfrom
Open
Fix f-string debug format parsing for Python 3.8+ ({expr=})#118aryanyk wants to merge 1 commit intogoogle:masterfrom
aryanyk wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Issue #115, where Python 3.8+ f-string debug format ({expr=}) fails to parse correctly and raises:
The fix is scoped to Python 3.8–3.11, which are within pasta’s supported range.
Background
Python 3.8 introduced debug f-strings:
Unlike regular f-strings, {expr=}:
The current logic in visit_FormattedValue assumes that conversion must be introduced by '!', which causes parsing to fail.
Root Cause
When parsing {expr=}:
Fix
The fix updates visit_FormattedValue to:
This matches CPython’s behavior.
Tests
Added test_fstring_debug_format covering:
Verification
Tests pass on:
Notes
Python 3.12+ introduces PEP 701 (PEG-based f-string parsing), which is a separate compatibility issue and not addressed here.